Skip to content

Conversation

@iuwqyir
Copy link
Contributor

@iuwqyir iuwqyir commented Apr 3, 2025

[Dashboard] Feature: Update API path format and add token lookup endpoint

Notes for the reviewer

This PR updates the API path format in insightBlueprints.ts to use curly braces for path parameters (e.g., changing /v1/transactions/:contractAddress to /v1/transactions/{contractAddress}). This standardizes our path format to match OpenAPI specifications.

How to test

The changes can be verified by checking the updated paths in the playground interface to ensure they display correctly with the new format.


PR-Codex overview

This PR focuses on updating the API path parameters in the insightBlueprints to use curly braces {} instead of colons :. This change aims to standardize the path parameter syntax across the API specifications.

Detailed summary

  • Updated path parameters from : to {} for various API endpoints, including:
    • Get contract transactions
    • Get wallet transactions
    • Get contract events
    • Get token transfers
    • Get ERC-20, ERC-721, ERC-1155 balances
    • Resolve
    • Get contract ABI and metadata
    • Get NFT owners and transfers
    • Force refresh collection and token metadata

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2025 0:16am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 3, 2025 0:16am
login ⬜️ Skipped (Inspect) Apr 3, 2025 0:16am
thirdweb-www ⬜️ Skipped (Inspect) Apr 3, 2025 0:16am
wallet-ui ⬜️ Skipped (Inspect) Apr 3, 2025 0:16am

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 3, 2025 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 3, 2025 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 3, 2025 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 3, 2025 11:57 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2025

⚠️ No Changeset found

Latest commit: be59923

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Apr 3, 2025
Copy link
Contributor Author

iuwqyir commented Apr 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@iuwqyir iuwqyir marked this pull request as ready for review April 3, 2025 11:57
@iuwqyir iuwqyir requested review from a team as code owners April 3, 2025 11:57
@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.98%. Comparing base (6001f24) to head (cf02af0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6633   +/-   ##
=======================================
  Coverage   54.98%   54.98%           
=======================================
  Files         888      888           
  Lines       55753    55753           
  Branches     3816     3816           
=======================================
  Hits        30653    30653           
  Misses      25005    25005           
  Partials       95       95           
Flag Coverage Δ
packages 54.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.49 KB (0%) 950 ms (0%) 150 ms (+139.34% 🔺) 1.1 s
thirdweb (cjs) 129.89 KB (0%) 2.6 s (0%) 212 ms (+32.72% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 91 ms (+1765.48% 🔺) 204 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 48 ms (+2156.92% 🔺) 58 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 106 ms (+619.72% 🔺) 493 ms

@iuwqyir iuwqyir force-pushed the 04-03-fix_insight_blueprints_navigation branch from daf068d to 444db07 Compare April 3, 2025 12:01
@vercel vercel bot temporarily deployed to Preview – login April 3, 2025 12:01 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 3, 2025 12:01 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 3, 2025 12:01 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 3, 2025 12:01 Inactive
@iuwqyir iuwqyir force-pushed the 04-03-fix_insight_blueprints_navigation branch from 444db07 to be59923 Compare April 3, 2025 12:04
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 3, 2025 12:04 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 3, 2025 12:04 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 3, 2025 12:04 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 3, 2025 12:04 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 3, 2025

Merge activity

## [Dashboard] Feature: Update API path format and add token lookup endpoint

## Notes for the reviewer

This PR updates the API path format in `insightBlueprints.ts` to use curly braces for path parameters (e.g., changing `/v1/transactions/:contractAddress` to `/v1/transactions/{contractAddress}`). This standardizes our path format to match OpenAPI specifications.

## How to test

The changes can be verified by checking the updated paths in the playground interface to ensure they display correctly with the new format.

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the URL path parameters in the `insightBlueprints` to use curly braces `{}` instead of colons `:` for better clarity and consistency in API endpoints.

### Detailed summary
- Changed path parameters from `:paramName` to `{paramName}` for various endpoints:
  - `/v1/transactions/:contractAddress` to `/v1/transactions/{contractAddress}`
  - `/v1/wallets/:wallet_address/transactions` to `/v1/wallets/{wallet_address}/transactions`
  - Updated multiple other endpoints similarly, including:
    - `/v1/events/:contractAddress` to `/v1/events/{contractAddress}`
    - `/v1/tokens/transfers/:contract_address` to `/v1/tokens/transfers/{contract_address}`
    - `/v1/nfts/:contract_address` to `/v1/nfts/{contract_address}`
    - And many more throughout the file.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 04-03-fix_insight_blueprints_navigation branch from be59923 to cf02af0 Compare April 3, 2025 12:15
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 3, 2025 12:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 3, 2025 12:15 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 3, 2025 12:15 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 3, 2025 12:15 Inactive
@graphite-app graphite-app bot merged commit cf02af0 into main Apr 3, 2025
31 checks passed
@graphite-app graphite-app bot deleted the 04-03-fix_insight_blueprints_navigation branch April 3, 2025 12:19
@vercel vercel bot temporarily deployed to Production – thirdweb-www April 3, 2025 12:19 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 3, 2025 12:19 Inactive
@vercel vercel bot temporarily deployed to Production – login April 3, 2025 12:19 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 3, 2025 12:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants